IncomingHttpRequest updates #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-frmr
reviewed
Feb 15, 2024
| "open", | ||
| "public-ip", | ||
| "rand 0.8.5", | ||
| "regex", |
There was a problem hiding this comment.
is this crate still being used? i don't see it in the diff -- if not, please remove from Cargo.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, it is possible to bind an HTTP path in
http_serverwith a URL param like/test/:test-id, but it is not possible to get easy access to:test-idor the path that was originally bound.Solution
This PR forwards the
url_paramsand matchingbound_pathwhich are currently available in, but not being forwarded from,http_server.Here is the corresponding process_lib update
Docs Update
Corresponding docs PR
Notes
There will be a repo added that can be used to test http bindings and requests.