hotfix: use kit --features flag to pass simulation-mode and fix kit s #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-frmr
suggested changes
Mar 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
hyperware-ai/kit#101
Solution
@dr-frmr s solution was halfway there. Just needed to propagate the simulation-mode feature flag into the packages. This PR modifies
build.rsto use the new kit flag which is added in hyperware-ai/kit#107Docs Update
TODO: update the flags discussion in build & build_and_start.
Notes
Please take over this PR and the corresponding kit one hyperware-ai/kit#107 @dr-frmr
This is a hotfix and so should be merged directly to main. It bumps to 0.6.1.
Oh, one big note here: there may be weirdness wrt the merge because I branched off of 61ff56f, not HEAD (which is fccff76). Please confirm in merge that app_store has the feature flags in it!