fix: enforce ws-routing port #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…even at login/key reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Described in issue #281, the runtime was not properly enforcing that a direct node boots on its specified port for the ws-networking protocol. It was also impossible to specify this port at node-registration-time.
Solution
This PR adds a
--ws-portflag so that users can specify a desired ws-networking port at registration time. If this port is not available, the binary exits with a helpful error.Separately, the registration/login flow now enforces that the runtime can bind to and use the port specified in a node's onchain networking data if it is a direct node.
Docs Update
N/A