Skip to content

Conversation

0x70b1a5
Copy link
Contributor

Also, fix scrollbar issues.

To test:

  • rebuild kinode and launch a local node
  • confirm login page appearance OK
  • login
  • confirm homepage appearance OK
  • confirm app store appearance OK

@0x70b1a5
Copy link
Contributor Author

0x70b1a5 commented Mar 21, 2024

There's definitely some weirdness with the current setup, and you may wish to prevent merge until I write some docs (maybe with @willbach to cover things I don't yet know) about the particulars of modifying it. Or, just add that as a TODO and merge if it looks OK, as the UI is in need of some love anyway.

@0x70b1a5 0x70b1a5 requested review from dr-frmr and willbach March 27, 2024 17:32
@0x70b1a5
Copy link
Contributor Author

@dr-frmr @nick1udwig I think the present state is a good spot to cut a PR - the homepage hasn't been Vite-ified yet but there is enough to test and double-check in the Register flow that I would prefer to close this one out before moving on.

@0x70b1a5
Copy link
Contributor Author

TODOs as of now:

  • Vite up the Homepage
  • " " " App Store

Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"LGTM"

@0x70b1a5 0x70b1a5 merged commit 929d9e4 into main Apr 2, 2024
@0x70b1a5 0x70b1a5 deleted the tm/unify branch April 2, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants