Skip to content

Conversation

nick1udwig
Copy link
Member

@nick1udwig nick1udwig commented Apr 3, 2024

Problem

wasmtime 19.0.1 has some cool stuff

Solution

Bump the deps

Docs Update

hyperware-ai/hyperware-book#153

Notes

hyperware-ai/process_lib#69
hyperware-ai/kit#129

@nick1udwig nick1udwig marked this pull request as ready for review April 4, 2024 00:42
@nick1udwig nick1udwig requested a review from dr-frmr April 4, 2024 00:42
@nick1udwig
Copy link
Member Author

nick1udwig commented Apr 4, 2024

Please consider this, the process_lib & kit PRs as a package deal.

@dr-frmr :
For this update, process devs with existing processes will have to:

  1. Bump process_lib import:
    process_lib = { git = "https://github.com/kinode-dao/process_lib.git", rev = "84b3d84" }
    
  2. Bump wit_bindgen:
    wit_bindgen = "0.24.0"
    
  3. Use the newest kit:
    kit update
    
  4. Change the wit_bindgen::generate!() call to remove the exports field:
    wit_bindgen::generate!({
         path: "wit",
         world: "process",
    });
    
  5. If not using call_init!(), add export!() macro call:
    export!(Component);
    

@nick1udwig
Copy link
Member Author

I was worried this would break our Py & JS processes because I did not update the libs we use to build those (and even the most recent updates of those libs are not on wasmtime 19.0.1). But I think specifically because of this semver change, they still work! The WASI version between 17.0.1 (what those libs are on) and 19.0.1 must only differ by a patch -> we good. Tested and they work 🚀

@dr-frmr
Copy link
Contributor

dr-frmr commented Apr 5, 2024

Ok, so this is not a breaking change? Existing compiled apps run fine?

@nick1udwig
Copy link
Member Author

Ok, so this is not a breaking change? Existing compiled apps run fine?

Confirmed. I can run this binary using this kit and then, using kit on master,

kit n foo
kit bs foo

and it works 👍

$ kit f -r ~/git/kinode
...

 ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⢀⡠⠖⠉
 ⠁⠶⣤⣀⡀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣀⠔⠋⠀⠀⠀888    d8P  d8b                        888
 ⠀⠀⠈⢛⠿⣷⣦⣤⣀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣀⡤⠤⣴⡞⠁⠀⠀⠀⠀⠀888   d8P   Y8P                        888
 ⠀⠀⠀⠀⠙⠳⢾⣿⣟⣻⠷⣦⣤⣀⠀⠀⠀⠀⠀⠀⣾⣿⣿⣿⣿⠀⠀⠀⠀⠀⠀⠀888  d8P                               888
 ⠀⠀⠀⠀⠀⠀⠙⠲⣯⣿⣿⣿⣿⠽⢿⣷⣦⣤⣀⠀⢿⣿⣿⣿⣿⠀⠀⠀⠀⠀⠀⠀888d88K     888 88888b.   .d88b.   .d88888  .d88b.
 ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠲⠾⠿⣿⣿⣿⣿⣿⣿⣿⣷⣿⣿⣿⣿⣿⡀⠀⠀⠀⠀⠀⠀8888888b    888 888 "88b d88""88b d88" 888 d8P  Y8b
 ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠙⠛⣛⣯⣿⣿⣿⣿⣿⢿⣿⣿⣿⣿⡇⠀⠀⠀⠀⠀⠀888  Y88b   888 888  888 888  888 888  888 88888888
 ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠐⠛⡵⣿⣿⣿⣿⣿⣿⣿⣿⡇⠀⠀⠀⠀⠀⠀888   Y88b  888 888  888 Y88..88P Y88b 888 Y8b.
 ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠈⣱⣿⣿⣿⣿⣿⣿⡿⠁⠀⠀⠀⠀⠀⠀888    Y88b 888 888  888  "Y88P"   "Y88888  "Y8888
 ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⢀⣼⣿⣿⣿⣿⣿⡽⠋⠀⠀⠀⠀⠀⠀⠀⠀
 ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣰⣿⣿⡿⠿⠛⣫⡽⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀fake.os (indirect)
 ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣠⣾⣿⣯⣷⡞⠀⠀⠈⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀version 0.6.3
 ⠀⠀⠀⠀⠀⠀⠀⠀⠀⢀⣠⡾⣿⡿⣿⣿⣿⠁⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀a general purpose sovereign cloud computer
 ⠀⠀⠀⠀⠀⠀⠀⣠⠴⠛⠉⢰⡿⢱⡿⢹⡟⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀
 ⠀⠀⠀⠀⠀⠀⠉⠀⠀⠀⢠⡿⠁⡿⠁⡿⠃⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀
 ⠀⠀⠀⠀⠀⠀⠀⠀⠀⢠⠟⠀⡸⠁⠀⠁⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀
 ⠀⠀⠀⠀⠀⠀⠀⢀⠔⠁⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀
 networking public key: c71884b82f366b17cef3d18ab135c39ab1a67a5d9ceafe8670a4f4fae908ea35
Fri 09:31 http_server: running on port 8080
Fri 09:31 kns_indexer:sys: indexing on contract address 0x3807fBD692Aa5c96F1D8D7c59a1346a885F40B1C
Fri 09:31 chess:sys: started
Fri 09:31 app_store:sys: started
Fri 09:31 app_store:sys: indexing on contract address 0x18c39eB547A0060C6034f8bEaFB947D1C16eADF1
Fri 09:49 foo:template.os: begin

Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case I happily approve.

@nick1udwig nick1udwig merged commit 78e0aaa into develop Apr 6, 2024
@nick1udwig nick1udwig deleted the hf/bump-wasmtime-deps branch April 6, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants