Kernel: process restart even on crash #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We've gone back and forth on this, but the kernel currently cancels restarts for processes that crash. This turns out to be harmful to the overall application model, because it complicates the story for managing
OnExitbehavior and has the effect of making process crashes totally verboten. Processes need to be allowed to panic and recover, and Restart is our primary recovery mechanism. There are alternatives as described here but they are much more involved.Solution
Remove the carve-out for crashes and honor
OnExiton crash.Docs Update
N/A but we SHOULD document this in book somewhere: https://gist.github.com/dr-frmr/bd2a0dd299a083034c0ba79d46ba2899