Skip to content

Conversation

dr-frmr
Copy link
Contributor

@dr-frmr dr-frmr commented Apr 25, 2024

Problem

We've gone back and forth on this, but the kernel currently cancels restarts for processes that crash. This turns out to be harmful to the overall application model, because it complicates the story for managing OnExit behavior and has the effect of making process crashes totally verboten. Processes need to be allowed to panic and recover, and Restart is our primary recovery mechanism. There are alternatives as described here but they are much more involved.

Solution

Remove the carve-out for crashes and honor OnExit on crash.

Docs Update

N/A but we SHOULD document this in book somewhere: https://gist.github.com/dr-frmr/bd2a0dd299a083034c0ba79d46ba2899

Copy link
Member

@nick1udwig nick1udwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@dr-frmr dr-frmr merged commit 6ad4a3f into develop Apr 25, 2024
@dr-frmr dr-frmr deleted the dr/process-restart-even-on-crash branch April 25, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants