Skip to content

Conversation

barraguda
Copy link
Contributor

@barraguda barraguda commented Apr 26, 2024

Problem

kit PR

TODO:

  • check chain for existing KNS name, and replace rather than register if true [X]

Solution

{A brief description of how you solved the problem.}

Docs Update

Corresponding docs PR

Notes

{Any other information useful for reviewers.}

@barraguda barraguda changed the base branch from main to develop April 26, 2024 18:06
@barraguda barraguda marked this pull request as ready for review April 30, 2024 17:32
Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, LMK

use tokio::sync::mpsc;

mod eth;
mod fakenet;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be behind a feature flag? In general, please test compiling this PR in both simulation-mode and regularly, and make sure there are no compiler warnings about unused code in either compilation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it behind a flag for now even though I think there isn't a huge difference rn.

simulation-mode has a fair bit of previous and current unused variables in main.rs and register, we could do something like #![cfg_attr(feature = "simulation-mode", allow(unused))] in main.rs to surpress them..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to keep unused code flagged-out for maximum clarity

@nick1udwig
Copy link
Member

I think af877a0 broke this PR. See hyperware-ai/kit#140 (comment)

Base automatically changed from develop to main May 1, 2024 10:50
@dr-frmr dr-frmr changed the base branch from main to develop May 2, 2024 14:56
@barraguda
Copy link
Contributor Author

a local app_store deployment is now also used in addition to the kns_indexer on simulation mode. I added a template package to the start state, but anvil currently does not store/replay past events if starting from a previously saved state. This should happen in the future though!

Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few final changes.

It's really exciting that any userspace program will be able to leverage the simulation-mode flag to enter a testing environment complete with their own contracts potentially.

Once you make final changes, please go in and assign flags in order to remove all unused code warnings (without using the allow-unused flag!). It helps to use mod { blocks } if there are a bunch of functions that are all sim-mode only or vice versa. I will check for this before merge

use tokio::sync::mpsc;

mod eth;
mod fakenet;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to keep unused code flagged-out for maximum clarity

dr-frmr

This comment was marked as outdated.

Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait. Issue booting a real node.

Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working now for me.

@dr-frmr dr-frmr merged commit 1dbb036 into develop May 8, 2024
@dr-frmr dr-frmr deleted the bp/realfakenodes branch May 8, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants