Skip to content

Conversation

0x70b1a5
Copy link
Contributor

@0x70b1a5 0x70b1a5 commented Apr 29, 2024

Problems

  • The homepage uses an HTML template, populated in Rust, to serve its UI.
  • The homepage does not have a button to return to Valet for hosted users.
  • The app store does not have a home button to return the user to their main Kinode page.

Solution

  • Vite-ify the homepage.
  • Add the buttons.

Notes

The filename changes to the bundled css/js will conflict with #320 . It is recommended to merge #320 first, and then have me pull those changes in and rebuild the files before merging this PR.

@0x70b1a5 0x70b1a5 changed the base branch from main to develop April 29, 2024 21:02
@0x70b1a5 0x70b1a5 changed the title Tm/app store home button Vite-ify homepage Apr 30, 2024
Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#320 is merged, and this looks good. resolve conflicts and GTM

@0x70b1a5 0x70b1a5 force-pushed the tm/app-store-home-button branch from 4d54bd4 to a8a882f Compare April 30, 2024 19:13
@0x70b1a5
Copy link
Contributor Author

@dr-frmr sorry about the force push... still good to merge?

@0x70b1a5 0x70b1a5 merged commit 281ca7e into develop Apr 30, 2024
@0x70b1a5 0x70b1a5 deleted the tm/app-store-home-button branch April 30, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants