-
Notifications
You must be signed in to change notification settings - Fork 19
Widgets #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widgets #328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments -- code looks good overall.
The frontend has some minor issues to address -- as described in comment, I think 'favoriting' is better suited for browser localstorage as it turns out, given that it's not persisted between boots currently and doing so would involve turning homepage into a stateful app.
Style-wise, I think the widgets section simultaneously does not need a "Widgets" title/label, and needs to be clearer about what the widgets are. I think a good way to do this would be to make the maximum widget size smaller such that it's not taking up the full horizontal space, and add a label to each individual widget that notes which app it's from.
After these changes, let's get another review from @jtneev on pure design.
Edit: Oh also, I think we need to make it clear somehow that the "default" apps that get shown on homepage despite having zero frontend functionality are there just for... show? They should be gray or something and unclickable.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Style review:
- Icons need to be smaller, and if/when they overflow, needs to look a bit better -- cutoffs are choppy right now.
- Favorited apps still appearing in main list is confusing
- The two gear icons at different places on the right edge of the page are confusing. It's also weird that the settings page has a big icon in the apps list and also has a link in the corner. I propose we remove the system settings gear in top-right and use that location for the widgets settings modal.
- Widgets should be "in front of" apps that are downloaded but not favorited. Apps that are downloaded but not favorited need to be de-emphasized in general as this section will grow very large as a user downloads things.
A few more comments:
This is very close, nice work |
fix: make ws port selection explicit on boot
@jtneev @dr-frmr
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks good to go.
Problem
Solution
Docs Update
We don't mention in the Book that apps have to message homepage:sys in order to show up there - I'm not sure that writing a whole page about this is in-scope, especially given that we need this out ASAP.