Skip to content

Conversation

nick1udwig
Copy link
Member

Problem

We don't rebuild core processes when their src/ is changed.

Solution

When we are inside a directory that is contained in rerun_files, print all entries therein.

Docs Update

N/A

Notes

None

@nick1udwig nick1udwig requested a review from dr-frmr May 6, 2024 16:21
@dr-frmr
Copy link
Contributor

dr-frmr commented May 6, 2024

@nick1udwig is there an amortizeable performance cost to all this..? or is it negligible/cost of doing business

@nick1udwig
Copy link
Member Author

So the "correct" behavior is that on a rebuild we go and try to kit build all the packages/. I THINK this PR should do that, but I've thought like 5 iterations of build.rs should do that so...

In any case, kit build does a good job of rebuilding only when necessary. You can experience this yourself when you kit b a package: first time build takes a while; second time with no changes is nearly instant; third time with changes is usually 1-2 seconds on my machine.

@dr-frmr
Copy link
Contributor

dr-frmr commented May 7, 2024

Oh no I just meant performance of traversing all the directories to find changes and cargo-print them. I suppose that's meaningless compared to build time itself.

Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nick1udwig
Copy link
Member Author

Oh no I just meant performance of traversing all the directories to find changes and cargo-print them. I suppose that's meaningless compared to build time itself.

Ah, I see. Yeah, I think you are correct: small wrt overall build time.

@nick1udwig nick1udwig merged commit bb9ed76 into develop May 7, 2024
@nick1udwig nick1udwig deleted the hf/fix-build.rs branch May 7, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants