wit apis #335
Merged
wit apis #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Extremely exciting |
|
|
Conflicts:
Cargo.lock
kinode/Cargo.toml
kinode/packages/homepage/homepage/src/lib.rs
dr-frmr
reviewed
May 14, 2024
lib/src/core.rs
Outdated
| pub license: Option<String>, | ||
| pub screenshots: Option<Vec<String>>, | ||
| pub wit_version: Option<(u32, u32, u32)>, | ||
| pub dependencies: Vec<String>, |
There was a problem hiding this comment.
Let's make this an Option<Vec<String>> and please add the description of this field to the docstring for this type
There was a problem hiding this comment.
What is the purpose of having it be an Option when an empty vector accomplishes the same thing? JSON parsing optional field?
There was a problem hiding this comment.
Yeah, if we want this to be backwards-compatible, need to parse successfully when the field doesn't exist in JSON
dr-frmr
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to be able to publish APIs as WIT files.
Solution
TODO
Docs Update
hyperware-ai/hyperware-book#198
Notes
Sister PR