Skip to content

Conversation

0x70b1a5
Copy link
Contributor

Problem

  • change the "color dot" icons to deterministically show one of the designer's preset stock icons, on homepage and in appstore
  • appstore download/install/launch buttons are now all different colors to better show change of state in ui
  • appstore shows all apps on main page, paginated, and featured apps as chosen by Kinode
  • remove "ratings" from app page until feature is done
  • use the 🚫 mouse cursor for unclickable app icons

Testing

  • verify that system apps on homepage "all apps" have a designed icon and a 🚫 cursor if no web ui exists for it
  • verify that you can search for apps on the appstore
  • verify all listed apps show up in a scrollable view on the main appstore page
  • verify ratings aren't shown on app pages anymore
  • download an app with a ui. verify that the buttons for download, install, and launch are black/orange/white respectively

Notes

There are some superfluous @ts-ignore comments in an appstore ui file - I think my IDE is bugged because the exact same file isn't showing those errors in the homepage ui. It compiles and runs as expected all the same.

@0x70b1a5 0x70b1a5 requested a review from dr-frmr May 22, 2024 14:48
Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having all the SVGs in triplicate in the repo is really unfortunate.. is there a way to deduplicate these

@0x70b1a5
Copy link
Contributor Author

@dr-frmr lmk if there's a smarter way to do this

@0x70b1a5 0x70b1a5 requested a review from dr-frmr May 24, 2024 18:50
@dr-frmr dr-frmr merged commit f4c7c38 into develop May 24, 2024
@dr-frmr dr-frmr deleted the tm/app-icons branch May 24, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants