Skip to content

Tm/refactor networking info #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2024
Merged

Tm/refactor networking info #360

merged 2 commits into from
May 23, 2024

Conversation

0x70b1a5
Copy link
Contributor

Problem

  • Networking info API has changed and register-ui operations cannot complete.
  • UI spams local chain endpoint.

Solution

  • Update the networking info API in the UI.
  • Reduce local chain spam somewhat.

Testing

  • Register a new node via KNS.
  • Reset password, networking info, etc.
  • Register a new node via ENS.
  • Ditto
  • Login and confirm stability.

Notes

Was not able to test ENS locally (can sign up for an ethname and such if desired).

@dr-frmr dr-frmr changed the base branch from main to develop May 23, 2024 19:00
dr-frmr
dr-frmr approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@dr-frmr dr-frmr merged commit 8517603 into develop May 23, 2024
@dr-frmr dr-frmr deleted the tm/refactor-networking-info branch May 23, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dr-frmr dr-frmr dr-frmr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0x70b1a5 @dr-frmr