Skip to content

Conversation

0x70b1a5
Copy link
Contributor

@0x70b1a5 0x70b1a5 commented May 28, 2024

Problem

  • FE code around generating and setting networking keys is repeated.
  • (minor UI fix) No apps show up in dock on boot.

Solution

  • Refactor the identical logic.
  • Show App Store if no favorite apps.

Testing

  • Register a new node:
    • indirect with KNS
    • indirect with ENS
    • direct KNS
    • direct ENS
  • Reset the password.
  • Reset the networking info. Likewise... etc.
  • Claim an invite (are we still doing these?) and confirm you can start up a node.
  • Confirm App Store icon shows up on fresh node homepage dock.

Notes

Some paths remain untested; I don't have an ENS name yet, and haven't tried an invite.

Base automatically changed from dr/add-tcp to develop May 29, 2024 05:32
@0x70b1a5 0x70b1a5 requested a review from dr-frmr May 29, 2024 14:36
@0x70b1a5
Copy link
Contributor Author

#367

Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0x70b1a5 can you please resolve the merge conflict, then this is good to go

@0x70b1a5
Copy link
Contributor Author

0x70b1a5 commented May 31, 2024 via email

@0x70b1a5 0x70b1a5 merged commit bab2515 into develop May 31, 2024
@0x70b1a5 0x70b1a5 deleted the tm/refactor-keygen branch May 31, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants