feat: secure subdomains for settings, improvements to server and login #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Secure subdomains had rotted just a bit from disuse. Also, we are exposing sensitive APIs via HTTP frontends in the core distro.
Solution
This PR cleans up the subdomain logic at the runtime level, and switches the
settings:sys
app over to actually using them. It goes along with a commit in thedevelop
branch of process_lib.However, we still serve sensitive APIs from the
app_store:sys
frontend. I would switch that over too, but the homepage currently relies on fetching from those sensitive APIs in exactly the way we want to make impossible. As a result, we will need to change the homepage logic to fetch that data using in-node capabilities-controlled messaging and switch app store to secure-subdomains in that PR.Testing
Docs Update
TODO