Skip to content

Conversation

0x70b1a5
Copy link
Contributor

@0x70b1a5 0x70b1a5 commented Jun 3, 2024

Problem

  • quickhide widget button should have confirm dialogue
  • can't page apps
  • remove featured apps from all apps
  • feature dartfrog
  • app entries make too many requests to /apps

Testing

  • Try to hide a widget. Confirm popup asks permission.
  • Page apps.
  • Confirm no featured apps show up in appstore "all apps" section.
  • Find dartfrog in featured apps list.
  • On the main appstore page, verify the Network tab shows that only a couple requests to /apps have been made, as opposed to each app button making its own request.

Notes

Sorry about the messy rebase.

@0x70b1a5 0x70b1a5 changed the base branch from main to develop June 3, 2024 17:34
@0x70b1a5 0x70b1a5 force-pushed the tm/appstore-paging-fix branch from 06ee94a to 9648ba9 Compare June 3, 2024 17:47
@0x70b1a5 0x70b1a5 changed the base branch from develop to dr/app-store-rewrite June 3, 2024 17:47
@dr-frmr
Copy link
Contributor

dr-frmr commented Jun 3, 2024

np, rebase looks good

@dr-frmr dr-frmr merged commit fc5e60f into dr/app-store-rewrite Jun 3, 2024
@dr-frmr dr-frmr deleted the tm/appstore-paging-fix branch June 3, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants