Skip to content

Kinomap #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Jul 5, 2024
Merged

Kinomap #379

merged 33 commits into from
Jul 5, 2024

Conversation

barraguda
Copy link
Contributor

@barraguda barraguda commented Jun 5, 2024 •
edited
Loading

WIP.

notes:

  • current setting of ip, port and pubkey takes 3 txs. Quick on local, but will be a single multicall once we get it into the contracts. [x]
  • no sending KnsUpdates to net:sys yet, need to determine when we've indexed enough logs to determine a node "complete" to send to net [x]
  • separate core process that indexes all notes and their values? (I suspect a better approach would be a process that has good library functions, and can index/subscribe on demand instead)
  • currently registering a name will not include it's .dev/.os top level zone. This is due to how kit loads state from json, and it doesn't include events (that the kns_indexer should pick up). This is an open anvil issue that I might take a look at to fix, or we have to reconsider fakenet approach [x]

@barraguda barraguda mentioned this pull request Jun 5, 2024
Closed
@barraguda barraguda mentioned this pull request Jun 10, 2024
Merged
barraguda added 21 commits June 10, 2024 15:50
@barraguda
kimap: update register flow
f8c28e2
@barraguda
kimap: fix kns
3c6e406
@barraguda
fakenet: kimap multicall
3e0ab55
@barraguda
kimap kns: rudimentary net updates
0ef56fc
@barraguda
fakenet: modify port registration
2aac98e
@barraguda
kns_indexer -> kimap_indexer
37e7dde
@barraguda
hotfix: kimap_indexer manifest
cdb0525
@barraguda
hotfix2 kimap manifest.json
aa6179b
@barraguda
kimap: update contract addresses, app_store indexing
1da68b4
@barraguda
net: AddName, app_store & kns_indexer: update process_lib, integrations
535a0ca
@barraguda
app_store: add temp racecondition fix
d635732
@barraguda
app_store: combined note logic getting
a2333a7
@barraguda
app_store: UI new connectors, abis, contracts
ff89003
@barraguda
app_store UI: remove ethers
49215d7
@barraguda
app_store: working on-parish
0b05ea2
@barraguda
app_store: remove old events
fe832b1
@barraguda
register_ui: start refactor...
afc1589
@barraguda
register_ui: kimap register
ea0f652
@barraguda
register_ui: reset
c6d5ebe
@barraguda
register_ui: further cleanup
ff00829
@barraguda
kimap: subscribe to specific note events
ddf7889
dr-frmr
dr-frmr reviewed Jul 1, 2024
View reviewed changes
kinode/packages/app_store/pkg/ui/assets/Arc-R3PUWRPJ-SiUbLWTa.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these individual js asset files really really need to be compressed if you're going to commit them. we'll need to squash merge this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, same case for register_ui ones.. there are too many anyway, looking into compressing soon

dr-frmr
dr-frmr reviewed Jul 1, 2024
View reviewed changes
kinode/packages/app_store/app_store/src/utils.rs
Comment on lines 78 to +85
pub fn app_store_filter(state: &State) -> eth::Filter {
let notes = vec![keccak256("~metadata-uri"), keccak256("~metadata-hash")];

eth::Filter::new()
.address(eth::Address::from_str(&state.contract_address).unwrap())
.from_block(state.last_saved_block)
.events(EVENTS)
.topic3(notes)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so cool

@dr-frmr dr-frmr changed the title 0.9 kimap Develop 0.9 Jul 5, 2024
@dr-frmr dr-frmr marked this pull request as ready for review July 5, 2024 19:22
@dr-frmr dr-frmr changed the title Develop 0.9 Kinomap Jul 5, 2024
dr-frmr
dr-frmr approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dr-frmr dr-frmr merged commit e7ca58c into develop Jul 5, 2024
@dr-frmr dr-frmr deleted the bp/kinomap branch July 5, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dr-frmr dr-frmr dr-frmr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@barraguda @dr-frmr