notify #414
notify #414
Conversation
| ); | ||
|
|
||
| const tryRebuildIndex = useCallback(async () => { | ||
| if (!window.confirm('Are you sure you want to rebuild the app index? This may take a few seconds.')) { |
| setFavoriteApps: (favoriteApps: PersistentStore['favoriteApps']) => set({ favoriteApps }), | ||
| toggleWidgetVisibility: (package_name: string) => { | ||
| const { widgetSettings } = get() | ||
| if (!window.confirm(`Really hide this widget?`)) { |
There was a problem hiding this comment.
i really dislike this alert box. IMO it needs to either be an in-page confirmation or have no confirmation at all. i'm not sure why this action needs to be confirmed, given how straightforward it is to re-toggle the widget on.
another option would be to completely remove the "hide widget" button from the home screen and only allow that operation in the settings modal. that would be my preference.
| @@ -0,0 +1,266 @@ | |||
| #![feature(let_chains)] | |||
| use std::collections::HashMap; | |||
|
|
|||
There was a problem hiding this comment.
remove blank line in between use statements please
| "grant_capabilities": [ | ||
| "http_server:distro:sys" | ||
| ], | ||
| "public": true |
There was a problem hiding this comment.
should the notify app really be public? shouldn't other apps need to request messaging capabilities in order to push notifications? wondering what the overall security model for this program should look like
|
Appstore fixes moved to #418 |
2 participants
Problem
Solution
Testing
Notes
This is very much a v0.1 for notify, but I think "push things to a widget" is a suitable v0.1 if we're being honest. The next feature is silencing processes. Actual device push notifs will be blocked until the mobile app is approved for TestFlight.
Also, I found some merge conflicts in the Settings and Chess
Cargo.lockfiles that had been committed at some point in the past. I took the more recent of each version where necessary, but would have preferred to regenerate them (deleting them and thenkit band/or rebuilding binary didn't cut it).