fix revoke all behavior, make caps printing on verbosity=3 cleaner #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue #416
Solution
It seems like revoking all capabilities on process spindown wasn't working for a while, which led to us not observing this issue. Now that RevokeAll is operating as expected, removing capabilities generated by a process when it gets killed or crashes, we need to re-grant capabilities in the OnExit::Restart case.
I came up with a simpler solution: adding a flag to the kill procedure that simply skips over the RevokeAll call. Then I use that flag in the Restart case on process spindown.
Testing
See #416
Docs Update
We should thoroughly document this whole thing -- I'll get on that
Notes
Also made capabilities print more nicely in terminal on verbosity 3.