Skip to content

Conversation

dr-frmr
Copy link
Contributor

@dr-frmr dr-frmr commented Jul 2, 2024

Problem

Issue #416

Solution

It seems like revoking all capabilities on process spindown wasn't working for a while, which led to us not observing this issue. Now that RevokeAll is operating as expected, removing capabilities generated by a process when it gets killed or crashes, we need to re-grant capabilities in the OnExit::Restart case.

I came up with a simpler solution: adding a flag to the kill procedure that simply skips over the RevokeAll call. Then I use that flag in the Restart case on process spindown.

Testing

See #416

Docs Update

We should thoroughly document this whole thing -- I'll get on that

Notes

Also made capabilities print more nicely in terminal on verbosity 3.

Copy link
Member

@nick1udwig nick1udwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised 👍

Interesting use of metadata field. I don't know that I feel great about it, but it is backwards compatible

@dr-frmr dr-frmr merged commit bfa7034 into develop Jul 3, 2024
@dr-frmr dr-frmr deleted the dr/add-no-revoke-to-kill branch July 3, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants