fix caps #434
Merged
fix caps #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release candidate
…ditional conditional removed in workflow
dr-frmr
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Caps don't work properly. This is because of the
contains_key()call here: https://github.com/kinode-dao/kinode/blob/main/kinode/src/kernel/mod.rs#L990Solution
contains_key()wants aPartialEqas well as aHash.PartialEqJSON-ifies theparamsfield before comparison, butHashdoes not. MakeHashJSON-ifyparams.Testing
In the
kinode-book/src/code, you cankit ton all but thehttppackages and it will fail on main, but work on this branch.Docs Update
N/A
Notes
I also merged the hotfix commits here. The actual fix is commit 7413646