Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Resolves #429
Solution
/
path but we are not on a secure subdomain, this lets us redirect to the same path (including query params) after login.Testing
The cases to test are:
/
/chess:chess:sys
and see redirect after login/chess:chess:sys?foo=bar
and see redirect after login including query param/chess:chess:sys
and see redirect after login (secure subdomain)/chess:chess:sys?foo=bar
and see redirect after login including query param (secure subdomain)To test 4&5, use commit b4395e0 which has
settings:settings:sys
served on secure subdomain. the subsequent commit (dc93350) set it back to insecure.Docs Update
None
Notes
There is an interesting behavior where you can login to a secure subdomain when the insecured node has not been logged in. I think this was always the case. Not sure if it is a desired behavior or not.
h/t @bacwyls