Deduplicate frontend stuff: app store, homepage, register-ui #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our frontend situation was unsustainable. 3 separate repos with different build processes and tons of random duplicated files everywhere.
Solution
Remove all frontend build files and unify runtime build process in
build.rs. Deduplicate styling and SVGs by having homepage serve them all at root path and link to them elsewhere.Testing
Delete entire repo and re-clone then build. This will give a clean starting point. Note that NPM is now a build dependency for runtime.
Docs Update
N/A
Notes
NPM as a dependency for building the runtime isn't great, but in practice, we (core/runtime developers) all have to have NPM anyways because we all need to frequently touch the frontends. It's better to have everything unified to create a stable product, and the users are completely unaffected.