app_store: new API and split backend #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-frmr
reviewed
Aug 14, 2024
Comment on lines
19
to
25
| record download-request { | ||
| package-id: package-id, | ||
| download-from: option<string>, // note, might be too much implicit complexity, | ||
| // but: download-from received locally, is an instruction where to download-from | ||
| // and if received from remote, is an instruction where to send, where the "download-from" came from. | ||
| desired-version-hash: string, | ||
| } |
There was a problem hiding this comment.
refactor into remote-download-request with no download-from field, and local-download-request with download-from: string
|
|
||
| record download-response { | ||
| success: bool, | ||
| error: option<string>, |
There was a problem hiding this comment.
change error into an enum type that lists all possible download errors, change download-response into a Result at the top level, so like Result<(), DownloadError>
dr-frmr
reviewed
Aug 15, 2024
There was a problem hiding this comment.
make sure to delete this from final PR
dr-frmr
reviewed
Aug 16, 2024
|
merging into develop now, I'll tweak the UI slightly with a separate PR later, hiding some of the more advanced features from users by default to not overload the pages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP