Skip to content

Conversation

nick1udwig
Copy link
Member

Problem

It'd be cool to serve docs with the core binary

Solution

Add a docs core application to serve the book

Testing

# Build it, e.g.,
cargo +nightly build -p kinode --features "simulation-mode"

# Run it, e.g.,
kit f -r path/to/kinode/target/debug/kinode

# Login to frontend
# Click Docs app

Docs Update

None

Notes

Expect an increase in binary size by ~3MB and memory footprint by a little less than 10MB, see hyperware-ai/hyperware-book#244

@nick1udwig nick1udwig requested a review from dr-frmr August 10, 2024 00:16
Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great to me. The memory usage bump is annoying but makes sense.

@nick1udwig nick1udwig merged commit 1a584e9 into develop Aug 13, 2024
@nick1udwig nick1udwig deleted the hf/add-docs-package branch August 13, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants