Skip to content

Conversation

dr-frmr
Copy link
Contributor

@dr-frmr dr-frmr commented Aug 14, 2024

Problem

Build.rs still wonky, see #480

Solution

Attempt to both make build script maximally sensitive to updates while skipping rebuild if only build-outputs have changed since last build. Seems to fix #480

Testing

build runtime,
change elements,
use SKIP_BUILD_FRONTEND flag,
etc

Docs Update

N/A

Notes

Let's test this on all the platforms we develop on frequently

@dr-frmr dr-frmr requested a review from nick1udwig August 14, 2024 15:45
@dr-frmr dr-frmr changed the base branch from main to develop August 14, 2024 15:45
Copy link
Member

@nick1udwig nick1udwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to resolve #480 for me. I did:

kit f -r $PATH_TO_KINODE
cp -r ${PATH_TO_KINODE}/kinode/packages/docs ${PATH_TO_KINODE}/kinode/packages/mocks
# MacOs version of `sed`
sed -i '' 's/docs/mocks/' ${PATH_TO_KINODE}/kinode/packages/mocks/metadata.json

kit f -r $PATH_TO_KINODE

noting that it does not rebuild in the second kit f

Still -- it does seem like an improvement over current build.rs, hence approval 👍

@dr-frmr dr-frmr merged commit 8cafb50 into develop Aug 15, 2024
@dr-frmr dr-frmr deleted the dr/build-script-output-reruns-skip-ui branch August 15, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: build.rs does not build new core packages unless you scorch earth

2 participants