Skip to content

Conversation

nick1udwig
Copy link
Member

@nick1udwig nick1udwig commented Aug 26, 2024

Problem

#509

Solution

Don't include timestamps in archives

Testing

Build, output hash, then build again.

Docs Update

None

Notes

None

@nick1udwig
Copy link
Member Author

nick1udwig commented Aug 26, 2024

On this branch:

$ cargo +nightly build -p kinode && ~/git/tg-notify/tg-notify.py 
...
$ sha1sum target/debug/kinode
6f6fa5f7569800c4d2cbb704c6512099a4c48e77  target/debug/kinode
$ touch kinode/packages/app_store/app_store/src/lib.rs 
$ cargo +nightly build -p kinode && ~/git/tg-notify/tg-notify.py 
...
$ sha1sum target/debug/kinode
6f6fa5f7569800c4d2cbb704c6512099a4c48e77  target/debug/kinode

@nick1udwig
Copy link
Member Author

nick1udwig commented Aug 27, 2024

On develop:

$ cargo +nightly build -p kinode && ~/git/tg-notify/tg-notify.py
...
$ sha1sum target/debug/kinode
f221475ed5be6135d5576cb877744ab97cfa9ee3  target/debug/kinode 
$ touch kinode/packages/app_store/app_store/src/lib.rs 
$ cargo +nightly build -p kinode && ~/git/tg-notify/tg-notify.py 
...
$ sha1sum target/debug/kinode
a5e47334b662ff68ca48db658b53ca64a4fd38ef  target/debug/kinode

@nick1udwig nick1udwig marked this pull request as ready for review August 27, 2024 00:06
Copy link
Collaborator

@dolled-possum dolled-possum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--release builds are now fully identical from build to build. For example, from this commit, you will always get a byte count of 39771448 and a shasum of ba82424d3d8a9aac29e0d72903b3a63848a54dd5.

@dolled-possum dolled-possum merged commit 3d15d78 into develop Aug 27, 2024
@dolled-possum dolled-possum deleted the hf/reproducible-builds branch August 27, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants