Skip to content

Conversation

dr-frmr
Copy link
Contributor

@dr-frmr dr-frmr commented Aug 27, 2024

Problem

Current login reset-keys flow is fixed to .os TLZ

Solution

Add optional TLZ argument to name entry so that we can still fix TLZ for main registration flow, but user can reset any node ID they own.

Testing

1. mint regular .os name to confirm fixed flow works (don't need to actually execute txn)
2. reset regular .os name (reset text box will contain full name including .os)
3. mint non-.os name (i used .kino)
4. reset non-.os name 

Docs Update

N/A

Notes

I considered fixing .os in the blue box next to name entry if user is resetting a .os name, but having the text box be consistently the full name on the reset page seemed easier to understand.

@dr-frmr dr-frmr requested a review from nick1udwig August 27, 2024 12:10
Copy link
Member

@nick1udwig nick1udwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dr-frmr dr-frmr merged commit 601803b into develop Aug 29, 2024
@dr-frmr dr-frmr deleted the dr/reset-node-tlz-agnostic branch August 29, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants