kernel: increase event loop queue size & error if full #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Nodes doing heavy work could sometimes freeze. We chased this down to be associated with the event loop queue getting filled & then deadlocking when processing a message that put >1 messages on the event loop.
https://discord.com/channels/1186394868336038080/1186684706700410962/1278437204749844611
Solution
For now, simply increase the queue size. This is a bandaid.
@dr-frmr recommended using an unbounded queue. The reasons I chose to instead increase the queue size & panic, outputting an error message if the queue is full are:
panic!()
replaced by, e.g., the backpressure mechanism (likely a newSendError
variant)Testing
Run providerfren.os with develop vs this branch
Docs Update
None
Notes
None