Skip to content

Conversation

nick1udwig
Copy link
Member

Problem

A broken process_lib function led to some broken code here.

Solution

Use fixed process_lib code & fix code here.

Testing

Does it work? Note master should work as well

Docs Update

None

Notes

None

@nick1udwig nick1udwig requested a review from barraguda August 29, 2024 05:47
@dr-frmr
Copy link
Contributor

dr-frmr commented Aug 29, 2024

Can we put out process_lib 0.9.1 and upgrade all usages in runtime to that new version?

Copy link
Contributor

@barraguda barraguda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thank you! tested app_store downloads interactions with this, lgtm

@barraguda
Copy link
Contributor

barraguda commented Aug 29, 2024

actually @nick1udwig , should we add open_or_create_dir() as a helper function to process_lib? seems like something we would use reasonably often.
Same with open_or_create_file()?

potential PR here: hyperware-ai/process_lib#92
can update usage in core too

edit: no new helpers needed, just a further adjustment in open_dir!

@barraguda barraguda merged commit a8b4e85 into develop Aug 29, 2024
@barraguda barraguda deleted the hf/fix-app_store-vfs-open-dir branch August 29, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants