eth: fix remote provider #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. dont unsubscribe, since subs are de-duped by alloy; if you unsub one mint, e.g., you unsub all 2. cache eth requests 3. retry eth requests once on rpc error
barraguda
reviewed
Aug 30, 2024
barraguda
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
nice!
I think something we can do in the near future to make the caching more robust (and for potential further deduplication of eth requests) is to specify our get_logs requests more thoroughly.
Saving state in kns & app_store probably too, but mainly getting a block number at boot, then specifying from_block -> to_block in the filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
providerfren.os still freezes
Solution
To solve the cause of the freeze:
It is still unsettling that not handling unsubs properly leads to a freeze, and that needs to be run down, but these changes seem to solve the cause.
Testing
See if providerfren.os is still alive (it is running this runtime version)
Docs Update
None
Notes
None