Skip to content

Conversation

dr-frmr
Copy link
Contributor

@dr-frmr dr-frmr commented Sep 3, 2024

Problem

As suggested here, it would be better for developer experience if unbound HTTP subpaths beneath a process-path (like mynode.com/chess:distro:sys/asdf) would default to the behavior of the base path (/chess:distro:sys/ in this case).

Solution

In the HTTP server module, add a fallback if a path is not recognized that matches on the process ID and a root path (/) binding.

We need to keep the overall behavior as-is because every path-structure (which can have URL params, etc) should be possible to configure (whether it's local-only, authenticated, etc). But for many apps, such as ones that use react router to serve 'pages', it's convenient to bind the root path once and let everything resolve to that.

Testing

1. navigate to unbound subpaths in an app
2. navigate to bound subpaths, ensure those work

Docs Update

N/A

Notes

Test this on release candidate

@dr-frmr dr-frmr marked this pull request as ready for review September 4, 2024 04:30
@dr-frmr dr-frmr merged commit 86b9590 into develop Sep 4, 2024
1 check passed
@dr-frmr dr-frmr deleted the dr/http-bind-generous branch September 4, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant