app_store: always respond with error; use process_macros #522
Conversation
|
@bitful-pannul ptal and in particular please look at I'm also not certain that the |
| println!("{error_message}"); | ||
| Response::new() | ||
| .body(AppStoreResponse::SendError(error_message)) | ||
| .send() | ||
| .unwrap(); | ||
| } | ||
| Ok(message) => { | ||
| if let Err(e) = handle_message(&our, &mut state, &mut http_server, &message) { | ||
| println!("error handling message: {:?}", e); | ||
| let error_message = format!("error handling message: {e:?}"); | ||
| println!("{error_message}"); |
There was a problem hiding this comment.
are we sure we want to print with full vebosity here? I'll test with some basic interactions to see if it doesn't muddle up terminal too much
There was a problem hiding this comment.
Not sure about it. Previous behavior was verbosity 0, so just maintaining that. Happy to change.
There was a problem hiding this comment.
I set it it to verbosity 1 and removed the response, it's not really ever hit or listened to. Added some clarifications to the verbosity prints of chain and downloads so one knows where they come from.
|
Ty @bitful-pannul 🚀 |
2 participants
Problem
kitSolution
Testing
kit rhangs because f9f9ce8 and earlier had a bug and app_store does not issue a Response and so HTTP server never issues an HTTP Response and sokithangs.Docs Update
None
Notes
process_macros required some reworking of variant names. Rust compiler got mad about
::Errorvariants alongside theTryFromtype Errordefinitions in process_macros (whcih are required for TryFrom). Solved by changing::Errorvariant names to::Err. We should probably document this somewhere.