Skip to content

Conversation

dr-frmr
Copy link
Contributor

@dr-frmr dr-frmr commented Sep 6, 2024

Problem

Docs app was making a ton of static bindings, leading to startup-cruft and excess memory usage (not truly an issue, but this way is cleaner)

Solution

Dynamically serve docs as HTTP requests occur

Testing

Use the app!

Docs Update

N/A

Notes

N/A

@dr-frmr dr-frmr requested a review from nick1udwig September 7, 2024 21:36
Copy link
Member

@nick1udwig nick1udwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the change.

One thing this makes me wonder about is whether we can make use of lazy load/inheritance with these different fancy methods for FS, etc. Its tricky because we can't assume what user is going to do after the method call.

Maybe it is fine: as of now, default is not 100% performant but is ergonomic; if you want 100% performance, you have to write it yourself using inheritance.

OTOH it would be v nice if we could somehow "do it for" people. I expect it'd be tricky tho.

@dr-frmr dr-frmr merged commit 5c81ffc into develop Sep 10, 2024
1 check passed
@dr-frmr dr-frmr deleted the dr/make-docs-app-dynamic branch September 10, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants