Skip to content

kernel: dont crash on bad wasm file #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

kernel: dont crash on bad wasm file #863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions hyperdrive/src/kernel/process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,17 +127,27 @@ async fn make_component_v1(
home_directory_path: PathBuf,
process_state: ProcessState,
) -> anyhow::Result<(ProcessV1, Store<ProcessWasiV1>, MemoryOutputPipe)> {
let component =
Component::new(&engine, wasm_bytes.to_vec()).expect("make_component: couldn't read file");
let our_process_id = process_state.metadata.our.process.clone();
let send_to_terminal = process_state.send_to_terminal.clone();

let component = match Component::new(&engine, wasm_bytes.to_vec()) {
Ok(c) => c,
Err(e) => {
t::Printout::new(
0,
t::KERNEL_PROCESS_ID.clone(),
format!("kernel: process {our_process_id} invalid wasm file: {e:?}"),
)
.send(&send_to_terminal)
.await;
return Err(e);
}
};

let mut linker = Linker::new(&engine);
ProcessV1::add_to_linker(&mut linker, |state: &mut ProcessWasiV1| state).unwrap();
let (table, wasi, wasi_stderr) = make_table_and_wasi(home_directory_path, &process_state).await;
wasmtime_wasi::p2::add_to_linker_async(&mut linker).unwrap();

let our_process_id = process_state.metadata.our.process.clone();
let send_to_terminal = process_state.send_to_terminal.clone();

let mut store = Store::new(
&engine,
ProcessWasiV1 {
Expand Down