Skip to content

fix #855 #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

fix #855 #865

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9162e41
fix #855
0x70b1a5 Oct 1, 2025
3de76c4
Merge branch 'develop' into tm/855
nick1udwig Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions hyperdrive/packages/homepage/ui/src/components/Home/components/OmniButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useEffect, useState, useRef } from 'react';
import React, { useEffect, useState, useRef, useCallback } from 'react';
import { useNavigationStore } from '../../../stores/navigationStore';
import classNames from 'classnames';
import { usePersistenceStore } from '../../../stores/persistenceStore';
Expand Down Expand Up @@ -72,7 +72,7 @@ export const OmniButton: React.FC = () => {
});
};

const handleMouseMove = (e: MouseEvent) => {
const handleMouseMove = useCallback((e: MouseEvent) => {
if (isMobile()) return;
console.log('omnibutton handleMouseMove', e);
e.stopPropagation();
Expand All @@ -90,9 +90,9 @@ export const OmniButton: React.FC = () => {
const newY = Math.max(30, Math.min(window.innerHeight - 30, dragStart.buttonY + deltaY));
setOmnibuttonPosition({ x: newX, y: newY });
}
};
}, [dragStart, isDragging, setOmnibuttonPosition]);

const handleMouseUp = () => {
const handleMouseUp = useCallback(() => {
if (isMobile()) return;
console.log('omnibutton handleMouseUp');
if (!isDragging && dragStart) {
Expand All @@ -101,19 +101,19 @@ export const OmniButton: React.FC = () => {
}
setDragStart(null);
setIsDragging(false);
};
}, [isDragging, dragStart, isRecentAppsOpen, toggleRecentApps, closeAllOverlays]);

// Mouse event listeners
useEffect(() => {
if (dragStart) {
document.addEventListener('mousemove', handleMouseMove), { passive: false };
document.addEventListener('mouseup', handleMouseUp), { passive: false };
document.addEventListener('mousemove', handleMouseMove);
document.addEventListener('mouseup', handleMouseUp);
return () => {
document.removeEventListener('mousemove', handleMouseMove), { passive: false };
document.removeEventListener('mouseup', handleMouseUp), { passive: false };
document.removeEventListener('mousemove', handleMouseMove);
document.removeEventListener('mouseup', handleMouseUp);
};
}
}, [dragStart, isDragging]);
}, [dragStart, isDragging, handleMouseMove, handleMouseUp]);

// Handle window resize to keep button in bounds
useEffect(() => {
Expand Down