-
Notifications
You must be signed in to change notification settings - Fork 9
Update install.md to add Docker install instructions #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style comment: please add some newlines to follow our convention having one sentence per line to make maintenance easier (e.g. prose diffs in PRs are much more readable w/ one sentence per line).
I want to add some discussion of common permutations users who are less familiar with Docker will probably want to know how to do, e.g.
- Run multiple nodes (i.e. how to do port mapping properly & how to set up/use multiple volumes),
- Copying native home dir in/out of volumes.
I'm sure there will be others. Anyways, you don't have to add this here if you don't want; I can follow up and add it.
The other thing I want to wait on before merging is testing on MacOS. I'm updating a machine now to test on. Then we can decide whether to "fully recommend" Docker or whether we should still mainly recommend using native binaries with Docker as a secondary suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall comment: please add newlines between sentences so that each sentence is on its own line.
Other than that, I left some more specific comments. Please address comments if they are all clear and then merge when ready.
Thanks for the PR! 🚀
Can merge after 1-sentence-per-line is done |
added all the stuff you mentioned except copying native home dir in/out of a volume, due to my lack of experience with docker i'm not sure how to do that properly haha |
I can handle that, thanks for the changes! |
hyperware-ai/hyperdrive#299