Skip to content

Feat/ignore terminal handler #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Feat/ignore terminal handler #368

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7607242
ignore terminal
Gohlub Sep 4, 2025
db47428
Format Rust code using rustfmt
github-actions[bot] Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/build/wit_generator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,9 +932,17 @@ fn process_rust_project(project_path: &Path, api_dir: &Path) -> Result<Option<(S
let has_init = method.attrs.iter().any(|a| a.path().is_ident("init"));
let has_ws = method.attrs.iter().any(|a| a.path().is_ident("ws"));
let has_ws_client = method.attrs.iter().any(|a| a.path().is_ident("ws_client"));

if has_remote || has_local || has_http || has_init || has_ws || has_ws_client {
debug!(remote=%has_remote, local=%has_local, http=%has_http, init=%has_init, ws=%has_ws, ws_client=%has_ws_client, "Method attributes found");
let has_terminal = method.attrs.iter().any(|a| a.path().is_ident("terminal"));

if has_remote
|| has_local
|| has_http
|| has_init
|| has_ws
|| has_ws_client
|| has_terminal
{
debug!(remote=%has_remote, local=%has_local, http=%has_http, init=%has_init, ws=%has_ws, ws_client=%has_ws_client, terminal=%has_terminal, "Method attributes found");
// Validate original Rust function name
validate_name(&method_name, "Function")?; // Error early if name invalid
let func_kebab_name = to_kebab_case(&method_name);
Expand All @@ -954,6 +962,11 @@ fn process_rust_project(project_path: &Path, api_dir: &Path) -> Result<Option<(S
continue;
}

if has_terminal {
debug!(method_name = %method_name, "Found [terminal] function, skipping signature generation (terminal handlers are ignored by WIT generator)");
continue;
}

// Generate signature structs. `generate_signature_struct` calls `rust_type_to_wit`,
// which populates `global_used_types` with all custom types found in parameters/return types.
if has_remote {
Expand Down Expand Up @@ -986,7 +999,7 @@ fn process_rust_project(project_path: &Path, api_dir: &Path) -> Result<Option<(S
} else {
// Method in hyperprocess impl lacks required attribute - Error
return Err(eyre!(
"Method '{}' in the #[hyperprocess] impl block is missing a required attribute ([remote], [local], [http], [init], [ws] or [ws_client]). Only methods with these attributes should be included.",
"Method '{}' in the #[hyperprocess] impl block is missing a required attribute ([remote], [local], [http], [init], [ws], [ws_client], or [terminal]). Only methods with these attributes should be included.",
method_name
));
}
Expand Down