Skip to content

incompatible with ES Modules #591

@turadg

Description

@turadg

#587 was merged and then modified in #590 to be released in 1.5.0.

I tried replacing our patch with 1.5.0 and it still creates some non-JS imports:

export const createRPCQueryClient = async ({ rpcEndpoint, }) => {
    const tmClient = await Tendermint34Client.connect(rpcEndpoint);
    const client = new QueryClient(tmClient);
    return {
        agoric: {
            swingset: (await import('./swingset/query.rpc.Query')).createRpcQueryExtension(client),
            vbank: (await import('./vbank/query.rpc.Query')).createRpcQueryExtension(client),
            vstorage: (await import('./vstorage/query.rpc.Query')).createRpcQueryExtension(client),
        },
    };
};

Maybe those cases were neglected in crafting the option. But I think in those cases it should always include .js. I'm confused why the #590 turned the extension restoration into an option and especially why it made the characters of the file extension configurable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions