Convert remaining pattern library pages to newer Library components#175
Merged
Conversation
esanzgar
approved these changes
Aug 30, 2021
Contributor
esanzgar
left a comment
esanzgar
left a comment
There was a problem hiding this comment.
I pointed to a couple typos and suggestions.
Contributor
Author
|
@esanzgar Thanks for your thorough review of this and catching some little typos and things! |
Make a small CSS-layout change to prevent this page from being huge
lyzadanger
force-pushed
the
component-page-conversion
branch
from
eea6ac2 to
4856b90
Compare
Codecov Report
@@ Coverage Diff @@
## main #175 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 158 158
Branches 55 55
=========================================
Hits 158 158 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finishes the conversion of pattern-library pages over to
Librarycomponents and removes unused components and styles.There are a number of areas of improvements for follow-up, but I want to address them subsequently. A few obvious items:
ButtonComponentspage in particular looks crowded and hard to scanLayoutFoundationspage is not responsive because of the examples on itBut this does move us into a better position to address all that, as the pattern-library pages will all be on the same...page :) (using the same components).
Fixes #162