Skip to content

Use angular constant instead of hardcoded string #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use angular constant instead of hardcoded string #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4649526
Use angular constant instead of hardcoded string
allevo Apr 3, 2014
cfa84e5
Udate README.md
allevo Apr 3, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

follow these step:

- Set 'YOUR GOOGLE ACCOUNT' in googleanalyticis.js placeholder with your google account id
- Create angular constant GOOGLE_ACCOUNT with your google account id (http://docs.angularjs.org/api/auto/object/$provide#constant)
- Add the service to your angular js app module:

``var app = angular.module('myapp', ['analytics']) {
Expand Down
4 changes: 2 additions & 2 deletions analyticsService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
var _gaq = _gaq || [];

angular.module('analytics', []).run(['$http', function($http) {
angular.module('analytics', []).run(['$http', 'GOOGLE_ACCOUNT', function($http, GOOGLE_ACCOUNT) {

_gaq.push(['_setAccount', 'YOUR GOOGLE ACCOUNT']);
_gaq.push(['_setAccount', GOOGLE_ACCOUNT]);
_gaq.push(['_trackPageview']);

var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
Expand Down