-
Notifications
You must be signed in to change notification settings - Fork 14
refactor: Adapt contracts file tree #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the contracts file tree by consolidating interface and facet contracts into more organized directories. It moves from a modules/
structure to direct interfaces/
and facets/
directories, and removes outdated interface files that are now relocated.
- Move interface contracts from
modules/interfaces/
tointerfaces/
- Move facet contracts from
modules/facets/
tofacets/
- Update import paths throughout the codebase to reflect the new directory structure
Reviewed Changes
Copilot reviewed 54 out of 64 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
test/utils/IexecWrapper.ts | Update import path for IexecPoco1__factory |
test/byContract/IexecPoco/IexecPoco1.test.ts | Update import paths for IexecPoco1 interfaces |
slither.config.json | Update filter paths to use new interfaces directory |
hardhat.config.ts | Update exclusion paths and remove legacy interface exclusions |
deploy/0_deploy.ts | Update comments and variable names from "modules" to "facets" |
contracts/tools/testing/slither/*.sol | Update import paths to use new facets directory |
contracts/tools/testing/*.sol | Update import paths for interfaces and facets |
contracts/interfaces/*.sol | Update relative import paths and add new interface files |
contracts/facets/*.sol | Update relative import paths and comments referencing modules |
contracts/IexecInterface*.sol | Remove files relocated to interfaces directory |
.solcover.js | Update exclusion path to use new facets directory |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/diamond #238 +/- ##
================================================
Coverage 83.60% 83.60%
================================================
Files 38 38
Lines 1214 1214
Branches 225 225
================================================
Hits 1015 1015
Misses 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Migration steps:
receive
andfallback
behavior inDiamond.sol
Module
toFacet
in contracts namesDiamond.sol
feature/diamond
indevelop
Old tree:
New tree: