Update deployment CI #228
Merged
Update deployment CI #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zguesmi
commented
Jul 25, 2025
zguesmi
commented
Jul 25, 2025
zguesmi
had a problem deploying
to
arbitrumSepolia
GitHub Actions
Failure
zguesmi
had a problem deploying
to
arbitrumSepolia
GitHub Actions
Failure
zguesmi
commented
Jul 25, 2025
zguesmi
had a problem deploying
to
arbitrumSepolia
GitHub Actions
Failure
zguesmi
commented
Jul 25, 2025
zguesmi
had a problem deploying
to
arbitrumSepolia
GitHub Actions
Failure
zguesmi
had a problem deploying
to
arbitrumSepolia
GitHub Actions
Failure
zguesmi
had a problem deploying
to
arbitrumSepolia
GitHub Actions
Failure
zguesmi
had a problem deploying
to
arbitrumSepolia
GitHub Actions
Failure
zguesmi
had a problem deploying
to
arbitrumSepolia
GitHub Actions
Failure
There was a problem hiding this comment.
Pull Request Overview
Updates the deployment CI/CD workflow to streamline contract deployment automation. The PR removes manual deployment validation steps, consolidates environment variables, and standardizes RPC URL configuration across networks.
Key changes:
- Removed manual deployment validation and environment-based conditions
- Consolidated environment variables to use
DEPLOYER_PRIVATE_KEYandRPC_URL - Updated hardhat configuration to use fallback RPC URL patterns for CI environments
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/deploy-smart-contracts.yml | Removes validation job, simplifies deployment workflow, and consolidates environment variables |
| .github/workflows/main.yml | Adds workflow_call trigger and concurrency control |
| hardhat.config.ts | Updates network configurations to use standardized environment variables with fallbacks |
| .env.template | Creates template for environment variables used in local development |
| config/config.json | Updates salt value for deployment configuration |
| deployments/arbitrumSepolia/*.json | Updates contract addresses and adds deployment metadata |
gfournieriExec
approved these changes
Jul 25, 2025
Le-Caignec
reviewed
Jul 25, 2025
| # npm run test:fuji | ||
| # fi | ||
|
|
||
| - name: Deploy contracts |
There was a problem hiding this comment.
I didn't see where the Admin is set up ?
There was a problem hiding this comment.
I will add it after merging the Diamond changes to avoid Git conflicts
Le-Caignec
approved these changes
Jul 25, 2025
|
To be merged in |
This was referenced Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration steps:
receiveandfallbackbehavior inDiamond.solModuletoFacetin contracts namesDiamond.solfeature/diamondindevelopIexecLibOrders_v5in config.jsonSuccessful deployment ✔️ :
https://github.com/iExecBlockchainComputing/PoCo/actions/runs/16525021658/job/46736006538