-
Notifications
You must be signed in to change notification settings - Fork 14
fix: Fix build with new storage layout #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix build with new storage layout #237
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/diamond #237 +/- ##
================================================
Coverage 83.60% 83.60%
================================================
Files 38 38
Lines 1214 1214
Branches 225 225
================================================
Hits 1015 1015
Misses 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes build issues after migrating to a new diamond storage layout in the IExec protocol. The changes primarily update storage slot references to use a new namespaced storage approach instead of hardcoded slot indices.
- Adds a utility function to calculate storage slot locations using a base storage location constant
- Updates test files to use the new storage slot calculation method instead of hardcoded slot indices
- Includes minor code improvements and formatting updates
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
utils/proxy-tools.ts | Adds getPocoStorageSlotLocation function for calculating namespaced storage slots |
test/byContract/IexecPoco/IexecPoco2-finalize.test.ts | Updates storage slot reference to use new calculation method |
test/byContract/IexecPoco/IexecPoco2-contribute-and-finalize.test.ts | Marks test as TODO/skipped |
test/byContract/IexecPoco/IexecPoco1.test.ts | Updates commented storage slot reference |
test/byContract/IexecEscrow/IexecEscrowNative.test.ts | Updates storage slot references and adds new test cases |
test/byContract/IexecConfiguration/IexecConfiguration.test.ts | Updates storage slot references and reformats test structure |
test/byContract/IexecAccessors/IexecAccessors.test.ts | Marks test as TODO/skipped |
package.json | Expands prettier formatting to include more file types |
deploy/0_deploy.ts | Removes TODO comment |
contracts/modules/facets/IexecPocoBoostFacet.sol | Refactors variable extraction and improves comments |
contracts/modules/facets/IexecAccessorsABILegacyFacet.sol | Fixes "Stack too deep" compilation errors |
.prettierignore | Adds ignore patterns for build artifacts and dependencies |
"solidity-coverage": "Fixing Hardhat's solidity-coverage: TypeError: provider.send is not a function" | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EOF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the formatter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in other PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 💪🏻
"coverage": "npx hardhat coverage", | ||
"verify": "npx hardhat verify", | ||
"format": "npx prettier --write ./contracts/**/*.sol", | ||
"format": "npx prettier --write '**/*.{js,ts,sol,json,yml}'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i agree with that. But we need to format many files in a dedicated PR if we do that !
Migration steps:
receive
andfallback
behavior inDiamond.sol
Module
toFacet
in contracts namesDiamond.sol
feature/diamond
indevelop