Re-use variable in IexecPoco2Delegate in contribute(...) function
#168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #168 +/- ##
========================================
Coverage 84.68% 84.68%
========================================
Files 35 35
Lines 1084 1084
Branches 221 221
========================================
Hits 918 918
Misses 166 166 ☔ View full report in Codecov by Sentry. |
zguesmi
approved these changes
Dec 18, 2024
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
gfournieriExec
changed the title
IexecPoco2Delegate in contribute(...) functionIexecPoco2Delegate in contribute(...) function
james-toussaint
approved these changes
Dec 18, 2024
| consensus.group[_resultHash] = group + delta; | ||
| consensus.total = consensus.total + delta; | ||
|
|
||
| // Check consensus |
There was a problem hiding this comment.
I wonder if we should/could do something here for gas footprint (outside of this PR if yes):
PoCo/contracts/modules/delegates/IexecPoco2Delegate.sol
Lines 386 to 388 in 3cd2e22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.