Skip to content

Re-use variable in IexecPoco2Delegate in contribute(...) function #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Re-use variable in IexecPoco2Delegate in contribute(...) function #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b3cba5
use already compute var group
gfournieriExec Dec 16, 2024
37e229a
update changelog
gfournieriExec Dec 17, 2024
d63499a
Merge branch 'develop' into feature/remove-reused-code
gfournieriExec Dec 18, 2024
3cd2e22
Update CHANGELOG.md
gfournieriExec Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- [x] `IexecPoco2Delegate.sol`

### Features
- Re-use variable in `IexecPoco2Delegate` in `contribute(...)` function. (#168)
- Remove unnecessary back and forth transfers in `IexecPoco2Delegate` happening during `claim(..)`. (#167)
- Remove references to blockscout v5. (#161)
- Migrate integration test files to Typescript & Hardhat:
Expand Down
2 changes: 1 addition & 1 deletion contracts/modules/delegates/IexecPoco2Delegate.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ contract IexecPoco2Delegate is IexecPoco2, DelegateBase, IexecEscrow, SignatureV
uint256 delta = Math.max(group, 1) * weight - group;

contribution.weight = Math.log2(weight);
consensus.group[_resultHash] = consensus.group[_resultHash] + delta;
consensus.group[_resultHash] = group + delta;
consensus.total = consensus.total + delta;

// Check consensus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should/could do something here for gas footprint (outside of this PR if yes):

Expand Down
Loading