fix: correct short and long options for getopt_long #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes incorrect option configurations for the getopt_long function in the secret provider agent. The changes correct the parameter requirements for command-line options to ensure proper argument parsing.
Key Changes
- Fixed
appIdoption to not require an argument (changed fromrequired_argumenttono_argument) - Fixed
savePathoption to require an argument (changed fromno_argumenttorequired_argument) - Reordered short options string to match the corrected long options configuration
cvmassistants/secretprovider/secret-provider-agent/src/secret_provider_agent.c
Show resolved
Hide resolved
aghiles-ait
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.