Skip to content

Conversation

@zguesmi
Copy link
Member

@zguesmi zguesmi commented May 13, 2025

Deployment tx.

$ npm run deploy -- --network <chain>

> sharing-contracts@2.0.0 deploy
> hardhat ignition deploy ignition/modules/DataProtectorSharingModule.cts --strategy create2 --network <chain>

✔ Confirm deploy to network <chain> (421614)? … yes

Hardhat Ignition 🚀

Deploying [ DataProtectorSharingModule ] with strategy create2

Batch #1
  Executed DataProtectorSharingModule#AddOnlyAppWhitelistRegistryImpl

Batch #2
  Executed DataProtectorSharingModule#AddOnlyAppWhitelistRegistryProxy

Batch #3
  Executed DataProtectorSharingModule#AddOnlyAppWhitelistRegistry
  Executed DataProtectorSharingModule#DataProtectorSharingImpl

Batch #4
  Executed DataProtectorSharingModule#DataProtectorSharingProxy

Batch #5
  Executed DataProtectorSharingModule#DataProtectorSharing

[ DataProtectorSharingModule ] successfully deployed 🚀

Deployed Addresses

DataProtectorSharingModule#AddOnlyAppWhitelistRegistryImpl - 0x22b1b78f84c553F7c7F12805DD454a39370837c0
DataProtectorSharingModule#AddOnlyAppWhitelistRegistryProxy - 0x52fF0E2335734cFEe678d5e614A772862A57E2e8
DataProtectorSharingModule#AddOnlyAppWhitelistRegistry - 0x52fF0E2335734cFEe678d5e614A772862A57E2e8
DataProtectorSharingModule#DataProtectorSharingImpl - 0x44a6fb3f082F951e0A550ebeA37d6d23449De251
DataProtectorSharingModule#DataProtectorSharingProxy - 0xC34ef5AbE5AeDA7852E2B1A6199DCbe051d7158d
DataProtectorSharingModule#DataProtectorSharing - 0xC34ef5AbE5AeDA7852E2B1A6199DCbe051d7158d

In the next PR:

  • Create a script that calls HH Ignition and import contracts for OZ upgrades.
  • Deploy using Create2 only on chains with CreateX support.
  • Add GA workflow to deploy and verify contracts.

@zguesmi zguesmi self-assigned this May 14, 2025
@zguesmi zguesmi changed the title feat(shring): Use Hardhat Ignition to deploy contracts feat(shring): Deploy contracts using Hardhat Ignition May 14, 2025
@zguesmi zguesmi marked this pull request as ready for review May 14, 2025 09:30
const proxyAdminOwner = m.getAccount(0);
const pocoAddress = env.POCO_ADDRESS || defaultPocoAddress;
const datasetRegistryAddress = env.DATASET_REGISTRY_ADDRESS || defaultDatasetRegistryAddress;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can keep the logs ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignition modules do not support console.log, actions are automatically logged by Hardhat, cf logs in the PR description.

@zguesmi zguesmi changed the title feat(shring): Deploy contracts using Hardhat Ignition feat(sharing): Deploy contracts using Hardhat Ignition May 14, 2025
@zguesmi
Copy link
Member Author

zguesmi commented May 14, 2025

Bypassing because red checks are irrelevant here.
image

@zguesmi zguesmi merged commit e7c3e71 into develop May 14, 2025
3 of 5 checks passed
@zguesmi zguesmi deleted the feature/hardhat-ignition branch May 14, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants