Skip to content

Conversation

@Le-Caignec
Copy link
Contributor

@Le-Caignec Le-Caignec commented Jul 24, 2025

No description provided.

@Le-Caignec Le-Caignec self-assigned this Jul 24, 2025
@Le-Caignec Le-Caignec changed the title feat: add core smart contract CI and deploy workflows with environmen… fix/dataProtector core fix ci Jul 24, 2025
@Le-Caignec Le-Caignec changed the title fix/dataProtector core fix ci fix: dataProtector core fix ci Jul 24, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@gfournieriExec gfournieriExec requested review from Copilot and zguesmi and removed request for Copilot July 24, 2025 13:59
@gfournieriExec gfournieriExec marked this pull request as ready for review July 24, 2025 14:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements CI/CD fixes and adds support for Arbitrum mainnet deployment. The changes refactor the deployment infrastructure by replacing the old workflow with a new modular CI/CD system and updating configuration to support multiple blockchain networks.

  • Replaced old deployment workflow with new modular CI/CD system using reusable workflows
  • Updated environment variable names for consistency (WALLET_PRIVATE_KEY → DEPLOYER_PRIVATE_KEY, ARBISCAN_API_KEY → EXPLORER_API_KEY)
  • Added support for Arbitrum mainnet network configuration and flexible API key management

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/smart-contract/package.json Added coverage script and reordered deploy script
packages/smart-contract/hardhat.config.ts Refactored network configurations and added Arbitrum mainnet support
packages/smart-contract/config/env.ts Updated environment variable names and added API verification configuration
packages/smart-contract/CHANGELOG.md Added changelog entry for CI fixes and Arbitrum mainnet support
packages/smart-contract/.nvmrc Set Node.js version to 20
packages/smart-contract/.env.template Updated environment variable names in template
.github/workflows/deploy-smart-contract.yml Removed old deployment workflow
.github/workflows/core-smart-contract-deploy.yml Added new deployment workflow with network selection
.github/workflows/core-smart-contract-ci.yml Added new CI workflow with coverage and static analysis

@codecov
Copy link

codecov bot commented Jul 24, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@gfournieriExec gfournieriExec force-pushed the fix/dataProtector-fix-ci branch from 9e7d7a7 to 0ea21a2 Compare July 24, 2025 14:53
Copy link
Contributor Author

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gfournieriExec and others added 2 commits July 25, 2025 10:22
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
@gfournieriExec gfournieriExec force-pushed the fix/dataProtector-fix-ci branch from 1b67ced to 34580db Compare July 25, 2025 08:22
@gfournieriExec gfournieriExec merged commit 5ca5d6c into main Jul 25, 2025
6 checks passed
@gfournieriExec gfournieriExec deleted the fix/dataProtector-fix-ci branch July 25, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants