-
Notifications
You must be signed in to change notification settings - Fork 10
fix: dataProtector core fix ci #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements CI/CD fixes and adds support for Arbitrum mainnet deployment. The changes refactor the deployment infrastructure by replacing the old workflow with a new modular CI/CD system and updating configuration to support multiple blockchain networks.
- Replaced old deployment workflow with new modular CI/CD system using reusable workflows
- Updated environment variable names for consistency (WALLET_PRIVATE_KEY → DEPLOYER_PRIVATE_KEY, ARBISCAN_API_KEY → EXPLORER_API_KEY)
- Added support for Arbitrum mainnet network configuration and flexible API key management
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/smart-contract/package.json | Added coverage script and reordered deploy script |
| packages/smart-contract/hardhat.config.ts | Refactored network configurations and added Arbitrum mainnet support |
| packages/smart-contract/config/env.ts | Updated environment variable names and added API verification configuration |
| packages/smart-contract/CHANGELOG.md | Added changelog entry for CI fixes and Arbitrum mainnet support |
| packages/smart-contract/.nvmrc | Set Node.js version to 20 |
| packages/smart-contract/.env.template | Updated environment variable names in template |
| .github/workflows/deploy-smart-contract.yml | Removed old deployment workflow |
| .github/workflows/core-smart-contract-deploy.yml | Added new deployment workflow with network selection |
| .github/workflows/core-smart-contract-ci.yml | Added new CI workflow with coverage and static analysis |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
9e7d7a7 to
0ea21a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
1b67ced to
34580db
Compare
No description provided.