Skip to content

Conversation

nabil-Tounarti
Copy link
Contributor

No description provided.

@nabil-Tounarti nabil-Tounarti self-assigned this Sep 11, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where the exit cause from pre-compute app failures was not being properly propagated to the worker API. The fix ensures that the actual exit cause returned by the pre-compute app is captured and sent to the worker, rather than always using a default "unknown issue" cause.

  • Refactored exit cause handling to capture the actual error from pre_compute_app.run()
  • Updated test to use a specific exit cause instead of the default unknown issue
  • Enhanced test verification with proper mock expectations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nabil-Tounarti nabil-Tounarti marked this pull request as ready for review September 11, 2025 11:34
@nabil-Tounarti nabil-Tounarti changed the title fix(pre-compute): ensure exit cause is propagated and sent to worker fix: ensure exit cause is propagated and sent to worker Sep 11, 2025
@nabil-Tounarti nabil-Tounarti merged commit e3310b9 into main Sep 11, 2025
2 checks passed
@nabil-Tounarti nabil-Tounarti deleted the bugfix/send-exit-cause-to-worker branch September 11, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants