[NFC] Improved predicate names.

Author: nate-chandler

include/swift/AST/AnyFunctionRef.h

@@ -272,10 +272,9 @@ class AnyFunctionRef {
                                          ->getReferenceStorageReferent();
           if (mapIntoContext)
             valueTy = AD->mapTypeIntoContext(valueTy);
-          YieldTypeFlags flags(
-              isYieldingDefaultMutatingAccessor(AD->getAccessorKind())
-                  ? ParamSpecifier::InOut
-                  : ParamSpecifier::LegacyShared);
+          YieldTypeFlags flags(isYieldingMutableAccessor(AD->getAccessorKind())
+                                   ? ParamSpecifier::InOut
+                                   : ParamSpecifier::LegacyShared);
           buffer.push_back(AnyFunctionType::Yield(valueTy, flags));
           return buffer;
         }

include/swift/AST/StorageImpl.h

@@ -95,7 +95,7 @@ inline bool isYieldingAccessor(AccessorKind kind) {
   }
 }
 
-inline bool isYieldingDefaultNonmutatingAccessor(AccessorKind kind) {
+inline bool isYieldingImmutableAccessor(AccessorKind kind) {
   switch (kind) {
   case AccessorKind::Read:
   case AccessorKind::Read2:
@@ -114,7 +114,7 @@ inline bool isYieldingDefaultNonmutatingAccessor(AccessorKind kind) {
   }
 }
 
-inline bool isYieldingDefaultMutatingAccessor(AccessorKind kind) {
+inline bool isYieldingMutableAccessor(AccessorKind kind) {
   switch (kind) {
   case AccessorKind::Modify:
   case AccessorKind::Modify2:

lib/AST/LifetimeDependence.cpp

@@ -109,7 +109,7 @@ static ValueOwnership getLoweredOwnership(AbstractFunctionDecl *afd) {
   }
   if (auto *ad = dyn_cast<AccessorDecl>(afd)) {
     if (ad->getAccessorKind() == AccessorKind::Set ||
-        isYieldingDefaultMutatingAccessor(ad->getAccessorKind())) {
+        isYieldingMutableAccessor(ad->getAccessorKind())) {
       return ValueOwnership::InOut;
     }
   }

lib/SIL/IR/SILFunctionType.cpp

@@ -2202,15 +2202,15 @@ static void destructureYieldsForCoroutine(TypeConverter &TC,
     return;
 
   // 'modify' yields an inout of the target type.
-  if (isYieldingDefaultMutatingAccessor(accessor->getAccessorKind())) {
+  if (isYieldingMutableAccessor(accessor->getAccessorKind())) {
     auto loweredValueTy =
         TC.getLoweredType(origType, canValueType, expansion);
     yields.push_back(SILYieldInfo(loweredValueTy.getASTType(),
                                   ParameterConvention::Indirect_Inout));
   } else {
     // 'read' yields a borrowed value of the target type, destructuring
     // tuples as necessary.
-    assert(isYieldingDefaultNonmutatingAccessor(accessor->getAccessorKind()));
+    assert(isYieldingImmutableAccessor(accessor->getAccessorKind()));
     destructureYieldsForReadAccessor(TC, expansion, origType, canValueType,
                                      yields);
   }

lib/SILGen/SILGenLValue.cpp

@@ -2227,7 +2227,7 @@ namespace {
       auto decl = cast<AccessorDecl>(Accessor.getFuncDecl());
 
       // 'modify' always returns an address of the right type.
-      if (isYieldingDefaultMutatingAccessor(decl->getAccessorKind())) {
+      if (isYieldingMutableAccessor(decl->getAccessorKind())) {
         assert(yields.size() == 1);
         return yields[0];
       }

lib/SILOptimizer/Analysis/DifferentiableActivityAnalysis.cpp

@@ -274,7 +274,7 @@ void DifferentiableActivityInfo::propagateVariedInwardsThroughProjections(
     if (auto *bai = dyn_cast<BeginApplyInst>(inst)) {
       if (auto *calleeFn = bai->getCalleeFunction()) {
         auto kind = getAccessorKind(calleeFn);
-        if (kind && isYieldingDefaultMutatingAccessor(*kind))
+        if (kind && isYieldingMutableAccessor(*kind))
           for (auto inoutArg : bai->getInoutArguments())
             propagateVariedInwardsThroughProjections(inoutArg, i);
       }
@@ -353,7 +353,7 @@ void DifferentiableActivityInfo::propagateUseful(
     if (auto *bai = dyn_cast<BeginApplyInst>(inst)) {
       if (auto *calleeFn = bai->getCalleeFunction()) {
         auto kind = getAccessorKind(calleeFn);
-        if (kind && isYieldingDefaultMutatingAccessor(*kind))
+        if (kind && isYieldingMutableAccessor(*kind))
           for (auto yield : bai->getYieldedValues())
             setUsefulAndPropagateToOperands(yield, i);
       }

lib/Sema/TypeCheckStorage.cpp

@@ -1201,7 +1201,7 @@ static Expr *buildStorageReference(AccessorDecl *accessor,
 
         // Check for availability of wrappedValue.
         if (accessor->getAccessorKind() == AccessorKind::Get ||
-            isYieldingDefaultNonmutatingAccessor(accessor->getAccessorKind())) {
+            isYieldingImmutableAccessor(accessor->getAccessorKind())) {
           diagnoseDeclAvailability(
               wrappedValue,
               var->getAttachedPropertyWrappers()[i]->getRangeWithAt(), nullptr,
@@ -2209,7 +2209,7 @@ synthesizeCoroutineAccessorBody(AccessorDecl *accessor, ASTContext &ctx) {
 
   // If this is a variable with an attached property wrapper, then
   // the accessors need to yield the wrappedValue or projectedValue.
-  if (isYieldingDefaultNonmutatingAccessor(accessor->getAccessorKind()) ||
+  if (isYieldingImmutableAccessor(accessor->getAccessorKind()) ||
       storageReadWriteImpl == ReadWriteImplKind::Modify) {
     if (auto var = dyn_cast<VarDecl>(storage)) {
       if (var->hasAttachedPropertyWrapper()) {
@@ -2226,8 +2226,7 @@ synthesizeCoroutineAccessorBody(AccessorDecl *accessor, ASTContext &ctx) {
   SourceLoc loc = storage->getLoc();
   SmallVector<ASTNode, 1> body;
 
-  bool isModify =
-      isYieldingDefaultMutatingAccessor(accessor->getAccessorKind());
+  bool isModify = isYieldingMutableAccessor(accessor->getAccessorKind());
 
   // Special-case for a modify coroutine of a simple stored property with
   // observers. We can yield a borrowed copy of the underlying storage
@@ -2543,7 +2542,7 @@ createCoroutineAccessorPrototype(AbstractStorageDecl *storage,
   SourceLoc loc = storage->getLoc();
 
   bool isMutating = storage->isGetterMutating();
-  if (isYieldingDefaultMutatingAccessor(kind))
+  if (isYieldingMutableAccessor(kind))
     isMutating |= storage->isSetterMutating();
 
   auto dc = storage->getDeclContext();
@@ -2580,7 +2579,7 @@ createCoroutineAccessorPrototype(AbstractStorageDecl *storage,
   if (FuncDecl *getter = storage->getParsedAccessor(AccessorKind::Get)) {
     asAvailableAs.push_back(getter);
   }
-  if (isYieldingDefaultMutatingAccessor(kind)) {
+  if (isYieldingMutableAccessor(kind)) {
     if (FuncDecl *setter = storage->getParsedAccessor(AccessorKind::Set)) {
       asAvailableAs.push_back(setter);
     }
@@ -2593,7 +2592,7 @@ createCoroutineAccessorPrototype(AbstractStorageDecl *storage,
   AvailabilityInference::applyInferredAvailableAttrs(accessor, asAvailableAs);
 
   // A modify coroutine should have the same SPI visibility as the setter.
-  if (isYieldingDefaultMutatingAccessor(kind)) {
+  if (isYieldingMutableAccessor(kind)) {
     if (FuncDecl *setter = storage->getParsedAccessor(AccessorKind::Set))
       applyInferredSPIAccessControlAttr(accessor, setter, ctx);
   }